Expected:
Observed:
End user unable to understand what “Mute” is supposed to do. There are many kinds of “mute” functionality in consumer and business products, this is ambiguous and confusing.
@matthewbirtch the way the ticket is filed it seems more like a UX improvement.
If we believe this is the right thing to do, I’m wondering if we can update the Compass design system, and then file a ticket to fix all the tooltips, rather than just these four?
Adding @jwilander @marianunez @streamer45 as #radar here, as I think having test automation to check for tooltips could be pretty straight forward–or maybe this could be an interesting use case for Copilot.
@it33_mattermost & @matthewbirtch, I’ve pushed feat: Add tooltips to channel info RHS top buttons by lieut-data · Pull Request #29170 · mattermost/mattermost · GitHub to address the four buttons reported here. As you might know, I’ve been exploring using LLMs to develop, and this PR was effectively written by Claude.
That being said, the tooling is not at a point where we could point an LLM at the repository and just fix everything. A significant amount of back and forth was required to produce a level of code I felt appropriate for review. I did benefit from the acceleration that comes from not having to remember exactly how to write a Cypress test, or exactly how to add an overlay… but I ended up having to fix so much that the resulting acceleration was net negative. Even the tests were not “free”.
Part of this might still be onboarding for me personally. @matthewbirtch, if we can identify other places for tooltips and the text we need, I’d be happy to continue this effort. But at present, there’s no panacea for automating this problem away.
Thanks Jesse. We need to do an audit of all instances of icon buttons across the app to ensure the tooltip is added. Having said that, I think there is work to do to have a unified icon button component in the code base to begin with, so we should probably start there. This could be a good next item for Daniel’s component library work that he’s doing.
For now, I’ve updated the Compass Design System docs for the Icon Button component to clarify that all icon buttons should have a tooltip, so maybe we can make this a required prop of the component if we can build a unified component. I’ve also updated the Tooltip documentation with some guidelines for usage of tooltips.
